Re: [PATCH v3 4/9] pci: pwrctrl: generic: support for the UPD720201/UPD720202 USB 3.0 xHCI Host Controller

[Neil Armstrong]

On 2/9/26 12:30, Manivannan Sadhasivam wrote:
> On Fri, Feb 06, 2026 at 03:50:32PM +0100, Neil Armstrong wrote:
> > Enable the generic pwrctrl driver to control the power of the
> > PCIe UPD720201/UPD720202 USB 3.0 xHCI Host Controller.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   drivers/pci/pwrctrl/generic.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/pci/pwrctrl/generic.c b/drivers/pci/pwrctrl/generic.c
> > index 08e53243cdbd..4a57a631362f 100644
> > --- a/drivers/pci/pwrctrl/generic.c
> > +++ b/drivers/pci/pwrctrl/generic.c
> > @@ -73,6 +73,10 @@ static const struct of_device_id pci_pwrctrl_slot_of_match[] = {
> >   	{
> >   		.compatible = "pciclass,0604",
> >   	},
> > +	/* Renesas UPD720201/UPD720202 USB 3.0 xHCI Host Controller */
> > +	{
> > +		.compatible = "pci1912,0014",
>
> No need to add the compatible to the driver. Just use the existing compatible as
> fallback in the binding/dts.

???

Sorry but this is insane, in no world a standalone PCIe USB controller could be qualified as
compatible as a pciclass,0604 slot.

Technically it would work just fine, but "compatibility" has a meaning....

Neil

> - Mani