Re: [PATCH v1] x86/smp: Set up exception handling before cr4_init()

From: Dave Hansen

Date: Mon Feb 09 2026 - 10:14:57 EST


On 2/9/26 00:16, Xin Li wrote:
> I’m not sure if Dave also wants to make BSP/AP boot code symmetric
> at the same time 😉

It's perfectly fine to do things one bit at a time. In this case,
cr4_init() is does two different things underneath the covers depending
on the state of CR pinning. If CR pinning as a feature is kicked out
influencing the early CPU boot code at _all_, then it certainly helps
the goal if making the AP/BSP code more symmetric.

So I very much prefer doing things one bit at a time, if we can.