Re: [PATCH v2 1/2] dt-bindings: Add binding document for cm36686

From: Krzysztof Kozlowski

Date: Mon Feb 09 2026 - 11:12:58 EST


On 09/02/2026 16:02, Erikas Bitovtas wrote:
>> Compatible says cm36672p... Confusing.
>> Why higher number is the fallback? Explain this in the commit msg.
>
> This driver was initially written for cm36686, which is an ambient light and
> proximity sensor. But cm36672p shares the same register and regfield layout, it
> is just missing an ambient light channel, because it is a proximity-only sensor
> and has no ambient light registers.

so cm36672p is the base and cm36686 is superset? Then the binding should
be named as the base. Just like the compatible list.

> In v1 the compatible looked like this:
> compatible:
> enum:
> - capella,cm36686
> - capella,cm36672p
>

You just removed entire context except my comment, so what do you refer
to exactly? I have many of such emails per day.

Best regards,
Krzysztof