Re: [PATCH 1/3] dt-bindings: firmware: Add tz-log doc

[Rob Herring]

On Thu, Jan 29, 2026 at 01:46:30AM -0600, Aaron Kling wrote:
> From: Kuldeep Singh <quic_kuldsing@xxxxxxxxxxx>
> 
> Add device-tree bindings for qcom tz-log. Exposes a debug
> interface for accessing and displaying diagnostic information
> related to secure code(Trustzone/QSEE).

$vendor * $firmware-component would be a lot of bindings which doesn't 
scale. This should be something cross-vendor and cross-component. 

> 
> Signed-off-by: Kuldeep Singh <quic_kuldsing@xxxxxxxxxxx>
> Signed-off-by: Aaron Kling <webgeek1234@xxxxxxxxx>
> ---
>  .../devicetree/bindings/firmware/qcom,tz-log.yaml  | 66 ++++++++++++++++++++++
>  1 file changed, 66 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,tz-log.yaml b/Documentation/devicetree/bindings/firmware/qcom,tz-log.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..e5c67ca1546c2d10f4c3b5979bf7b8a1a7dd2132
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/qcom,tz-log.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/firmware/qcom,tz-log.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TZLOG (Trust Zone log)
> +
> +maintainers:
> +  - Vikas Kumar Sharma <quic_vksharma@xxxxxxxxxxx>
> +
> +description:
> +  This exposes a debug interface for accessing and displaying diagnostic information
> +  related to secure code (Trustzone/QSEE).
> +
> +properties:
> +  compatible:
> +    const: qcom,tz-log
> +
> +  reg:
> +    maxItems: 1
> +
> +  qcom,hyplog-enabled:
> +    type: boolean
> +    description: Indicates(boolean) if driver supports HYP logger service.
> +
> +  hyplog-address-offset:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Register offset to get the HYP log base address.
> +
> +  hyplog-size-offset:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Register offset to get the HYP log size parameter.
> +
> +  rmlog-address:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Register offset to get resource manager log base address.
> +
> +  rmlog-size:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Register offset to get the resource manager log size parameter.
> +
> +  tmecrashdump-address-offset:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Define tme crashump DDR region starting offset.

Wouldn't 'reg' for all of this? Though I have no clue what's in 'reg' 
region.

> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        qcom_tzlog: tz-log@146bf720 {
> +            compatible = "qcom,tz-log";
> +            reg = <0x0 0x146bf720 0x0 0x3000>;
> +            qcom,hyplog-enabled;
> +            hyplog-address-offset = <0x410>;
> +            hyplog-size-offset = <0x414>;
> +        };
> +    };
> 
> -- 
> 2.52.0
>