Re: [RESEND PATCH v2] scsi: core: Add 'serial' sysfs attribute for SCSI/SATA

From: Bart Van Assche

Date: Mon Feb 09 2026 - 15:28:00 EST


On 2/9/26 11:31 AM, Igor Pylypiv wrote:
Instead, I will put a newline
manually and return the correct number of characters. PAGE_SIZE is passed
to scsi_vpd_lun_serial() so we don't sysfs_emit_at() to check it again.

buf[ret] = '\n';
return ret + 1;

This sounds good to me.

Thanks,

Bart.