Re: [PATCH v3 2/3] dma: amlogic: Add general DMA driver for A9

[Martin Blumenstingl]

Hi Xianwei Zhao,

On Fri, Feb 6, 2026 at 10:03 AM Xianwei Zhao via B4 Relay
<devnull+xianwei.zhao.amlogic.com@xxxxxxxxxx> wrote:
[...]
> +       /* PIO 4 bytes and I2C 1 byte */
> +       dma_dev->dst_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES | DMA_SLAVE_BUSWIDTH_1_BYTE);
I have not seen this way of writing two bits before.
Should this be:
    BIT(DMA_SLAVE_BUSWIDTH_4_BYTES) | BIT(DMA_SLAVE_BUSWIDTH_1_BYTE)
instead (similar to the line below)?

> +       dma_dev->directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);

Best regards,
Martin