回复: 回复: [PATCH v8 1/3] dt-bindings: soc: cix: document the simple-mfd syscon on Sky1 SoC

[Gary Yang]

Hi Krzysztof:

Thanks for your comments

> EXTERNAL EMAIL
> 
> On 10/02/2026 04:37, Gary Yang wrote:
> >>> +examples:
> >>> +  - |
> >>> +    syscon@16000000 {
> >>> +      compatible = "cix,sky1-s5-system-control", "syscon";
> >>> +      reg = <0x16000000 0x1000>;
> >>> +      #reset-cells = <1>;
> >>> +    };
> >>> diff --git a/include/dt-bindings/reset/cix,sky1-rst-fch.h
> >>> b/include/dt-bindings/reset/cix,sky1-rst-fch.h
> >>
> >> Filename must match compatible.
> >>
> >> I am pretty sure I gave such feedback to Cix before....
> >>
> >
> > Yes, You're right. I remember it. But please allow us to explain it.
> > This header file contains many macros for reset signals. We intend to use
> syscon as a common module.
> > So it is not only reset controller, it can also be used by other
> > modules in futher. If the file named by syscon, Maybe make confuse. All
> right?
> 
> Really? How?
> 
> Not able to find the header because it is randomly named would confuse more.
> You don't get exceptions from the rules. Multiple people before also asked for
> some special naming for whatever reasons. It's the last time I am asking you of
> it. Read the docs and follow it and we really do not care what internally you
> want, because you are contributing to GENERIC kernel so you must follow
> common and generic rules.
> 

Sorry, we don't challenge this rule. We study arch/riscv/boot/dts/spacemit/k1.dtsi.
In this file, syscon is used as clock controller and reset controller. The reset ID is defined
in file named include/dt-bindings/clock/spacemit,k1-syscon.h. I see what you said.
We will rename this file to cix,sky1-system-control.h. All right?

Best Regards
Gary

> 
> Best regards,
> Krzysztof