Re: [PATCH v2] staging: media: atomisp: fix block comment style
From: Andy Shevchenko
Date: Tue Feb 10 2026 - 04:46:28 EST
On Tue, Feb 10, 2026 at 05:23:11PM +0800, Ethan Lam wrote:
> Fixed all block comment style warnings by checkpatch.pl.
...
> /*
> * DFS progress is shown as follows:
> * 1. Target frequency is calculated according to FPS/Resolution/ISP running
> - * mode.
> + * mode.
> * 2. Ratio is calculated using formula: 2 * HPLL / target frequency - 1
> - * with proper rounding.
> + * with proper rounding.
> * 3. Set ratio to ISPFREQ40, 1 to FREQVALID and ISPFREQGUAR40
> - * to 200MHz in ISPSSPM1.
> + * to 200MHz in ISPSSPM1.
> * 4. Wait for FREQVALID to be cleared by P-Unit.
> * 5. Wait for field ISPFREQSTAT40 in ISPSSPM1 turn to ratio set in 3.
> */
Please, use your common sense. The above is false-positive.
...
> * The standard CSS2.0 API tells the following calling sequence of
> * dequeue ready buffers:
> * while (ia_css_dequeue_psys_event(...)) {
> - * switch (event.type) {
> - * ...
> - * ia_css_pipe_dequeue_buffer()
> - * }
> + * switch (event.type) {
> + * ...
> + * ia_css_pipe_dequeue_buffer()
> + * }
> * }
No way, really.
...
You need to read the code and change wisely. NAK for this version.
(I'm even not going to read the rest.)
--
With Best Regards,
Andy Shevchenko