Re: [PATCH] gpio: swnode: restore the swnode-name-against-chip-label matching
From: Andy Shevchenko
Date: Tue Feb 10 2026 - 05:07:28 EST
On Tue, Feb 10, 2026 at 10:48:06AM +0100, Bartosz Golaszewski wrote:
> Using the remote firmware node for software node lookup is the right
> thing to do. The GPIO controller we want to resolve should have the
> software node we scooped out of the reference attached to it. However,
> there are existing users who abuse the software node API by creating
> dummy swnodes whose name is set to the expected label string of the GPIO
> controller whose pins they want to control and use them in their local
> swnode references as GPIO properties.
>
> This used to work when we compared the software node's name to the
> chip's label. When we switched to using a real fwnode lookup, these
> users broke down because the firmware nodes in question were never
> attached to the controllers they were looking for.
>
> Restore the label matching as a fallback to fix the broken users but add
> a big FIXME urging for a better solution.
>
> Link: https://lore.kernel.org/all/aYmV5Axyfo76D19T@xxxxxxxxxxxxxxxxxx/
Should be
Link: https://lore.kernel.org/all/aYkdKfP5fg6iywgr@jekhomev/
Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko