Re: [PATCH 3/3] phy: qcom: edp: Add eDP phy mode switch support

[Yongxing Mou]

On 2/6/2026 7:02 PM, Konrad Dybcio wrote:
> On 2/5/26 10:20 AM, Yongxing Mou wrote:
> > Add DP/eDP switch support by splitting the PHY swing/pre-emphasis tables
> > into separate DP and eDP configurations. This allows the driver to select
> > the correct table based on the is_edp flag.
> >
> > Add a dedicated table for the SC7280/glymur platforms, as they are not
> > compatible with the others.
> >
> > Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
> > ---
>
> [...]
>
> > +static const u8 edp_swing_hbr2_hbr3_v3[4][4] = {
> > +	{ 0x0b, 0x11, 0x16, 0x1b },
> > +	{ 0x0b, 0x19, 0x1f, 0xff },
> > +	{ 0x18, 0x1f, 0xff, 0xff },
> > +	{ 0x1f, 0xff, 0xff, 0xff }
> > +};
> > +
> > +static const u8 edp_pre_emp_hbr2_hbr3_v3[4][4] = {
> > +	{ 0x0c, 0x15, 0x19, 0x1e },
> > +	{ 0x09, 0x14, 0x19, 0xff },
> > +	{ 0x0f, 0x14, 0xff, 0xff },
> > +	{ 0x0d, 0xff, 0xff, 0xff }
> > +};
>
> This is not quite in line with docs for kodiak. Now, if you have
> better/newer sequences than the HPG, I'm not objecting, but please
> cross-check
>
> the rest of this patch I think looks fine
>
> Konrad
Thanks for point that..
>> +static const u8 edp_swing_hbr2_hbr3_v3[4][4] = {
>> +	{ 0x0b, 0x11, 0x16, 0x1b },
here should be { 0x06, 0x11, 0x16, 0x1b }, arr[0][1]: 0x0b->0x06
does this looks fine? will check tables again..