Re: [PATCH v5 3/5] soc: qcom: pmic_glink: Add support for Glymur and Kaanapali

[Dmitry Baryshkov]

On Mon, Feb 09, 2026 at 12:49:13PM -0800, Anjelique Melendez wrote:
> On Glymur, a compute platform, and Kaanapali, a mobile platform, charger
> FW runs on SOCCP (another subsystem). SOCCP does not have any specific
> charger PDs defined. So, add support for Glymur and Kaanapali compatible
> strings.

Ideally, this needs a brief explanation that they are not compatible,
because of foo bar baz.

> 
> Signed-off-by: Anjelique Melendez <anjelique.melendez@xxxxxxxxxxxxxxxx>
> ---
>  drivers/soc/qcom/pmic_glink.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c
> index df2fd03d3b33..3042261578aa 100644
> --- a/drivers/soc/qcom/pmic_glink.c
> +++ b/drivers/soc/qcom/pmic_glink.c
> @@ -397,7 +397,15 @@ static const struct pmic_glink_data pmic_glink_adsp_data = {
>  	.charger_pdr_service_path = "msm/adsp/charger_pd",
>  };
>  
> +static const struct pmic_glink_data pmic_glink_soccp_data = {
> +	.client_mask = BIT(PMIC_GLINK_CLIENT_BATT) |
> +		       BIT(PMIC_GLINK_CLIENT_ALTMODE) |
> +		       BIT(PMIC_GLINK_CLIENT_UCSI),
> +};
> +
>  static const struct of_device_id pmic_glink_of_match[] = {
> +	{ .compatible = "qcom,glymur-pmic-glink", .data = &pmic_glink_soccp_data },
> +	{ .compatible = "qcom,kaanapali-pmic-glink", .data = &pmic_glink_soccp_data },
>  	{ .compatible = "qcom,pmic-glink", .data = &pmic_glink_adsp_data },
>  	{}
>  };
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry