Re: [PATCH v9 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay
From: Krzysztof Kozlowski
Date: Tue Feb 10 2026 - 07:51:23 EST
On 10/02/2026 13:42, Nihal Kumar Gupta wrote:
>
>
> On 09-02-2026 22:08, Krzysztof Kozlowski wrote:
>>> Krzysztof, Thanks for your review.
>>> All patches posted here were build‑tested and verified by the author.
>> Then please explain reported by Rob build-process warnings.
>
> The dt-binding for qcom,qcs8300-cci specifies two clocks:
> clock-names = "ahb", "cci";
>
> On Monaco, the CCI node currently defines:
> clock-names = "cpas_ahb", "cci";
>
> The dt-binding warns because it expects the clock-names to be "ahb" and
> "cci", while the Monaco DTS uses "cpas_ahb" instead of "ahb". The
> hardware works correctly, but the name doesn't match the binding.
> Renaming "cpas_ahb" to "ahb" aligns the DTS with the binding and clears
> the warning. Please advise if you prefer a different approach.
I said this was not build-time tested. I gave a proof of that.
You said it was build tested but you confirm it has build error.
Listen, when tools report you errors and maintainers say your code does
not pass basic tests, don't insist that this was basic tested.
It was not and discussing this just wastes our time. I am not going to
spend more time on this discussion, wasted already too much.
Best regards,
Krzysztof