Re: [PATCH 2/2] liveupdate: luo_file: remember retrieve() status
From: Pratyush Yadav
Date: Tue Feb 10 2026 - 08:31:55 EST
On Sat, Jan 31 2026, Pasha Tatashin wrote:
> On Mon, Jan 26, 2026 at 6:03 PM Pratyush Yadav <pratyush@xxxxxxxxxx> wrote:
[...]
>> diff --git a/include/linux/liveupdate.h b/include/linux/liveupdate.h
>> index a7f6ee5b6771..a543a3a8e837 100644
>> --- a/include/linux/liveupdate.h
>> +++ b/include/linux/liveupdate.h
>> @@ -21,7 +21,10 @@ struct file;
>> * struct liveupdate_file_op_args - Arguments for file operation callbacks.
>> * @handler: The file handler being called.
>> * @retrieved: The retrieve status for the 'can_finish / finish'
>
> Rename retrieved to retrieve_sts
Will fix. Thanks.
>
>> - * operation.
>> + * operation. A value of 0 means the retrieve has not been
>> + * attempted, a positive value means the retrieve was
>> + * successful, and a negative value means the retrieve failed,
>> + * and the value is the error code of the call.
>> * @file: The file object. For retrieve: [OUT] The callback sets
>> * this to the new file. For other ops: [IN] The caller sets
>> * this to the file being operated on.
>> @@ -37,7 +40,7 @@ struct file;
>> */
>> struct liveupdate_file_op_args {
>> struct liveupdate_file_handler *handler;
>> - bool retrieved;
>> + bool retrieve_sts;
>> struct file *file;
>> u64 serialized_data;
>> void *private_data;
[...]
--
Regards,
Pratyush Yadav