Re: [PATCH 3/5] iio: proximity: hx9023s: support firmware-name property

[Yasin Lee]

On Mon, Feb 9, 2026 at 4:02 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Mon, Feb 09, 2026 at 11:37:04AM +0800, Yasin Lee wrote:
> > Add an optional firmware-name property to specify the firmware file.
> > If not provided, the driver falls back to the default firmware name.
> >
> > Signed-off-by: Yasin Lee <yasin.lee.x@xxxxxxxxx>
> > ---
> >  drivers/iio/proximity/hx9023s.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/proximity/hx9023s.c b/drivers/iio/proximity/hx9023s.c
> > index eb4902d18d74..b680b89956bd 100644
> > --- a/drivers/iio/proximity/hx9023s.c
> > +++ b/drivers/iio/proximity/hx9023s.c
> > @@ -1089,6 +1089,7 @@ static int hx9023s_probe(struct i2c_client *client)
> >       struct device *dev = &client->dev;
> >       struct iio_dev *indio_dev;
> >       struct hx9023s_data *data;
> > +     const char *fw_name = "hx9023s.bin";
> >       int ret;
> >
> >       indio_dev = devm_iio_device_alloc(dev, sizeof(*data));
> > @@ -1111,6 +1112,10 @@ static int hx9023s_probe(struct i2c_client *client)
> >       if (ret)
> >               return dev_err_probe(dev, ret, "regulator get failed\n");
> >
> > +     ret = device_property_read_string(dev, "firmware-name", &fw_name);
>
> Incorrect order of patches, see submitting patches in DT dir about the
> order - documentation always comes first. This is here an undocumented ABI.
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
You're absolutely right, my apologies. I'll resend the series with the
correct order.

Best regards,
Yasin