Re: [PATCH] platform/x86: lenovo-wmi-{capdata,other}: Fix HWMON channel visibility
From: Ilpo Järvinen
Date: Tue Feb 10 2026 - 10:24:04 EST
On Sun, 08 Feb 2026 01:23:27 +0800, Rong Zhang wrote:
> The LWMI_SUPP_MAY_{GET,SET} macros are fundamentally broken. When I
> introduced them, I meant to check LWMI_SUPP_VALID *and* the
> corresponding bits for get/set capabilities. However, `supported &
> LWMI_SUPP_MAY_{GET,SET}' means *or*, so it accidentally passes the check
> when LWMI_SUPP_VALID is set.
>
> Fix them by only including the corresponding get/set bit without
> LWMI_SUPP_VALID. Meanwhile, rename them to LWMI_SUPP_{GET,SET} to make
> them less confusing.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: lenovo-wmi-{capdata,other}: Fix HWMON channel visibility
commit: 5a5203a45b063a594e89a2aeaf9e4923893a5b4c
--
i.