Re: [PATCH] iio: dac: max5522: use devm_regulator_get_enable_read_voltage()
From: Andy Shevchenko
Date: Tue Feb 10 2026 - 14:35:56 EST
On Tue, Feb 10, 2026 at 07:51:27PM +0200, Antoniu Miclaus wrote:
> Simplify probe by using devm_regulator_get_enable_read_voltage() to
> get, enable and read the regulator voltage in a single call, caching
> the value at probe time.
...
> - struct regulator *vrefin_reg;
> + unsigned short vref_mv;
vref_mV ?
...
> + state->vref_mv = ret / 1000;
"1000" --> "(MICRO / MILLI)" ?
(yes, this way with the parentheses).
--
With Best Regards,
Andy Shevchenko