Re: [PATCHv2 bpf-next 4/5] selftests/bpf: Add test for checking correct nop of optimized usdt

[Jiri Olsa]

On Tue, Feb 10, 2026 at 02:12:09PM +0000, bot+bpf-ci@xxxxxxxxxx wrote:
> > diff --git a/tools/testing/selftests/bpf/prog_tests/usdt.c b/tools/testing/selftests/bpf/prog_tests/usdt.c
> > --- a/tools/testing/selftests/bpf/prog_tests/usdt.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/usdt.c
> 
> [ ... ]
> 
> > +#ifdef __x86_64
>           ^^^^^^^^
> Should this be __x86_64__ (with trailing underscores) to match the standard
> GCC predefined macro? The call site in test_usdt() uses __x86_64__:
> 
> > @@ -516,6 +599,8 @@ void test_usdt(void)
> > #ifdef __x86_64__
> > 	if (test__start_subtest("basic_optimized"))
> > 		subtest_basic_usdt(true);
> > +	if (test__start_subtest("optimized_attach"))
> > +		subtest_optimized_attach();
> > #endif
> 
> Without the trailing underscores, the function definition will not be
> compiled on x86_64 while the call will be, leading to a linker error.

it actually compiles, interestingly enough __x86_64 is allowed as well,
but it's a typo.. will fix, thnx

jirka

> 
> 
> ---
> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
> 
> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21867569087
> 
> AI-authorship-score: low
> AI-authorship-explanation: The commit follows standard kernel selftest patterns with a natural coding style and contains a typo characteristic of human error rather than AI generation.
> issues-found: 1
> issue-severity-score: medium
> issue-severity-explanation: The mismatched preprocessor macro will cause a linker error on x86_64 builds, preventing the test from compiling.