Re: [PATCH v3] staging: rtl8723bs: remove redundant 'Adapter' variable in HalPhyRf_8723B

From: Ethan Tidmore

Date: Tue Feb 10 2026 - 17:47:36 EST


On Tue Feb 10, 2026 at 12:50 PM CST, Haroen Tmimi wrote:
> The variable Adapter was declared and initialized locally in
> an if-statement, but it shadowed a variable of the same name and
> value declared in the function scope (line 169).
>
> Removing the inner declaration allows the code to use the existing
> outer variable, resolving a -Wshadow warning.
>
> Signed-off-by: Haroen Tmimi <tmimiharoen@xxxxxxxxx>
> ---

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@xxxxxxxxx>

Thanks,

ET