Re: [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into a helper

[Dave Hansen]

On 2/10/26 15:20, Sohil Mehta wrote:
> Reviewed-by: Sohil Mehta <sohil.mehta@xxxxxxxxx>

Thanks!

> A minor nit:
> 
>> -	if (IFM(x86_family(sig->sig), x86_model(sig->sig)) >= INTEL_PENTIUM_III_DESCHUTES) {
>> -		unsigned int val[2];
>> -
>> -		/* get processor flags from MSR 0x17 */
>> -		native_rdmsr(MSR_IA32_PLATFORM_ID, val[0], val[1]);
>> -		sig->pf = 1 << ((val[1] >> 18) & 7);
>> -	}
>> +	sig->pf  = 1 << intel_get_platform_id();
> How about BIT(intel_get_platform_id())?

... and ack on that. I may fix it at application.