Re: [PATCH 1/6] x86/cpu: Break Vendor/Family/Model macros into separate header

From: Luck, Tony

Date: Tue Feb 10 2026 - 18:33:39 EST


On Tue, Feb 10, 2026 at 03:03:18PM -0800, Sohil Mehta wrote:
> On 2/10/2026 2:17 PM, Dave Hansen wrote:
>
> > The reality is that we have non-x86 code using an x86 header. That's
> > crazy and it's very very unusual and we're probably going to keep
> > accidentally breaking it.

Maybe the answer is to change the peci code to not do that crazy
include of an arch/x86 file and simply have its own copies of the
#define model numbers for the eight models it cares about?

If they add a ninth at some point, they have to change their code
anyway to add a "case INTEL_FOO:". So adding the model number to
their own local include file doesn't seem like much extra work.

-Tony