Re: [PATCH v2 2/2] xfs: add static size checks for ioctl UABI

[Wilfred Mallawa]

On Tue, 2026-02-10 at 16:35 +0100, Christoph Hellwig wrote:
> On Tue, Feb 10, 2026 at 03:59:44PM +1000, Wilfred Mallawa wrote:
> > From: Wilfred Mallawa <wilfred.mallawa@xxxxxxx>
> > 
> > The ioctl structures in libxfs/xfs_fs.h are missing static size
> > checks.
> > It is useful to have static size checks for these structures as
> > adding
> > new fields to them could cause issues (e.g. extra padding that may
> > be
> > inserted by the compiler). So add these checks to xfs/xfs_ondisk.h.
> > 
> > Due to different padding/alignment requirements across different
> > architectures, to avoid build failures, some structures are ommited
> > from
> > the size checks. For example, structures with "compat_" definitions
> > in
> > xfs/xfs_ioctl32.h are ommited.
> 
> Looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> I couldn't spot any whitespace issues either, although I'd personally
> drop the last empty line if I had to nitpick.

Fixed in V3, Thanks for the review!

Wilfred