Re: [PATCH 5/5] iio: proximity: hx9023s: add ACPI support

[Yasin Lee]

On Mon, Feb 9, 2026 at 4:44 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Mon, Feb 09, 2026 at 11:37:06AM +0800, Yasin Lee wrote:
> > Extend the hx9023s driver to support ACPI matching by adding TYHX9023
> > to the ACPI device ID table.
>
> ...
>
> > +#include <linux/acpi.h>
>
> Why?
>

Ack. I Will remove this.

> ...
>
> > +static const struct acpi_device_id hx9023s_acpi_match[] = {
> > +     { "TYHX9023", 0 },
>
> No ', 0' part, please.
>

Agreed. Thanks.

> > +     { }
> > +};
>
> ...
>
> And since you added a new ID, please add to the commit message if this is
> in a wild (and hence the vendor and model of the device that it has) and
> also an excerpt from DSDT to the comment block (after '---' line).
>

Hi Andy,

Thanks for your comments.
Regarding the ACPI ID "TYHX9023", it is for a product currently in the
late stages of development. We are in the process of formally
registering the "TYHX" Vendor ID with the UEFI Forum.
To ensure everything is compliant, I will withdraw this ACPI support
patch (5/5) for now. I will resubmit it as a standalone patch once the
ID registration is officially confirmed and I can provide the verified
DSDT evidence.
I will send v2 for the rest of the series (1-4) with your other
suggestions addressed.

Best Regards,
Yasin

> --
> With Best Regards,
> Andy Shevchenko
>
>