RE: [bug report] media: chips-media: wave5: Fix Null reference while testing fluster

[Nas Chung]

Hi, Dan.

>-----Original Message-----
>From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>Sent: Friday, February 6, 2026 10:41 PM
>To: jackson.lee <jackson.lee@xxxxxxxxxxxxxxx>
>Cc: linux-media@xxxxxxxxxxxxxxx; linux-kernel <linux-
>kernel@xxxxxxxxxxxxxxx>
>Subject: [bug report] media: chips-media: wave5: Fix Null reference while
>testing fluster
>
>[ Smatch checking is paused while we raise funding.  #SadFace
>  https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ]
>
>Hello Jackson Lee,
>
>Commit e66ff2b08e4e ("media: chips-media: wave5: Fix Null reference
>while testing fluster") from Nov 19, 2025 (linux-next), leads to the
>following Smatch static checker warning:
>
>	drivers/media/platform/chips-media/wave5/wave5-vpu.c:415
>wave5_vpu_probe()
>	error: 'dev->irq_thread' dereferencing possible ERR_PTR()
>
>drivers/media/platform/chips-media/wave5/wave5-vpu.c
>    327
>    328         dev->product_code = wave5_vdi_read_register(dev,
>VPU_PRODUCT_CODE_REGISTER);
>    329         ret = wave5_vdi_init(&pdev->dev);
>    330         if (ret < 0) {
>    331                 dev_err(&pdev->dev, "wave5_vdi_init, fail: %d\n", ret);
>    332                 goto err_clk_dis;
>    333         }
>    334         dev->product = wave5_vpu_get_product_id(dev);
>    335
>    336         INIT_LIST_HEAD(&dev->instances);
>    337
>    338         dev->irq = platform_get_irq(pdev, 0);
>    339         if (dev->irq < 0) {
>    340                 dev_err(&pdev->dev, "failed to get irq resource, falling
>back to polling\n");
>    341                 sema_init(&dev->irq_sem, 1);
>    342                 dev->irq_thread = kthread_run(irq_thread, dev, "irq
>thread");
>
>Add error checking for if kthread_run() fails?

Thanks for the report.

A fix has been proposed by Alper Ak in a separate thread:
https://lore.kernel.org/all/20260207103224.609938-1-alperyasinak1@xxxxxxxxx/
I'm going to check it and run tests on my side.

Thanks.
Nas.

>
>    343                 hrtimer_setup(&dev->hrtimer, &wave5_vpu_timer_callback,
>CLOCK_MONOTONIC,
>    344                               HRTIMER_MODE_REL_PINNED);
>
>regards,
>dan carpenter