Re: [PATCH v2 1/2] dt-bindings: gpio: add gpio-aggregator binding

[James Hilliard]

On Wed, Feb 11, 2026 at 1:19 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 11/02/2026 09:17, Krzysztof Kozlowski wrote:
> > On 11/02/2026 09:13, James Hilliard wrote:
> >> Document the gpio-aggregator virtual GPIO controller with a dedicated
> >> schema and compatible string.
> >>
> >> Also extend the GPIO AGGREGATOR MAINTAINERS entry to cover the new
> >> binding file.
> >
> > <form letter>
> > This is a friendly reminder during the review process.
> >
> > It seems my or other reviewer's previous comments were not fully
> > addressed. Maybe the feedback got lost between the quotes, maybe you
> > just forgot to apply it. Please go back to the previous discussion and
> > either implement all requested changes or keep discussing them.
> >
> > Thank you.
> > </form letter>
> >
>
> First thing which was missing (I did not even check the rest in such
> case): missing rationale for this patch, missing hardware description.

I added some more details to the commit message, this is a
virtual gpio driver though so AFAIU it's not hardware specific.

Use case is I have a device with something like 300 gpio
lines...and I want to name/group a small subset of those
lines for delegation to a userspace app rather than trying
to set 300 or something gpio-line-names values, also I'm
supporting multiple board variants and want to be able to
better compose the gpio difference with device tree overlays
using these virtual gpio groups essentially.

>
> Best regards,
> Krzysztof