Re: [PATCHv3 bpf-next 4/5] selftests/bpf: Add test for checking correct nop of optimized usdt

[bot+bpf-ci]

> diff --git a/tools/testing/selftests/bpf/prog_tests/usdt.c b/tools/testing/selftests/bpf/prog_tests/usdt.c
> --- a/tools/testing/selftests/bpf/prog_tests/usdt.c
> +++ b/tools/testing/selftests/bpf/prog_tests/usdt.c

[ ... ]

> +static void subtest_optimized_attach(void)
> +{
> +	struct test_usdt *skel;
> +	__u8 *addr_1, *addr_2;
> +
> +	/* usdt_1 USDT probe has single nop instruction */
> +	addr_1 = find_instr(usdt_1, nop1_nop5_combo, 6);
> +	if (!ASSERT_NULL(addr_1, "usdt_1_find_nop1_nop5_combo"))
> +		return;
> +
> +	addr_1 = find_instr(usdt_1, nop1, 1);
> +	if (!ASSERT_OK_PTR(addr_1, "usdt_1_find_nop1"))
> +		return;
> +
> +	/* usdt_1 USDT probe has nop,nop5 instructions combo */
> +	addr_2 = find_instr(usdt_2, nop1_nop5_combo, 6);

This comment says "usdt_1" but the code operates on "usdt_2". Should this
say "usdt_2 USDT probe has nop,nop5 instructions combo" to match the code?


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21898612624

AI-authorship-score: low
AI-authorship-explanation: The code follows standard kernel selftest patterns with natural commit message style, and the copy-paste comment error is a characteristically human mistake.
issues-found: 1
issue-severity-score: low
issue-severity-explanation: Comment/code mismatch in test file where comment says usdt_1 but code operates on usdt_2; does not affect test functionality.