Re: [PATCH 0/5] uniwill-laptop: Input-related improvements

[Werner Sembach]

Hi,

Am 11.02.26 um 00:29 schrieb Armin Wolf:
> This patch series contains a set of input-related improvements
> for the uniwill-laptop driver. The first patch renames the
> "fn_lock_toggle_enable" and "super_key_toggle_enable" sysfs attributes
> after it was discovered that the underlying hardware works differently
> than previously thought. This technically breaks user space
> applications using those sysfs attributes, but AFAIK no such users
> currently exist.

Just to note it down somewhere: Not every Uniwill device hast a shortcut to 
enable/disable the super key, but the programmatic switch seems to work on all 
devices (at least the ones I tested so far).

Best regards,

Werner

> The next two patches fix a potential crash and an issue with the fn
> lock status not being updated when using a key combination. The
> remaining patches ensure that when the users changes the fn lock
> status or enables/disables the super key using a key combination, a
> poll notification is being issued on the appropriate sysfs attr.
>
> Armin Wolf (5):
>    platform/x86: uniwill-laptop: Rename FN lock and super key lock attrs
>    platform/x86: uniwill-laptop: Fix crash on unexpected battery event
>    platform/x86: uniwill-laptop: Mark FN lock status as being volatile
>    platform/x86: uniwill-laptop: Handle FN lock event
>    platform/x86: uniwill-laptop: Handle super key lock events
>
>   .../ABI/testing/sysfs-driver-uniwill-laptop   |  10 +-
>   drivers/platform/x86/uniwill/uniwill-acpi.c   | 109 ++++++++++++------
>   2 files changed, 80 insertions(+), 39 deletions(-)