Re: [PATCH v9 18/21] wifi: nxpwifi: add core driver implementation

[Jeff Chen]

On Wed, Feb 11, 2026 at 10:36:22 AM +0100, Krzysztof Kozlowski wrote:

Hi Krzysztof,
Thanks for the review.

> 
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
>

I will update the commit message to use imperative mood as recommended in
the documentation.
 
> > +
> > +	/* Notify PM core we are wakeup source */
> > +	pm_wakeup_event(adapter->dev, 0);
> > +	pm_system_wakeup();
> > +
> > +	return IRQ_HANDLED;
> > +}
> > +
> > +static void nxpwifi_probe_of(struct nxpwifi_adapter *adapter)
> 
> NAK, you removed DT support thus cannot keep undocumented ABI.

Understood, and thanks for pointing this out.

> 
> 
> > +{
> > +	int ret;
> > +	struct device *dev = adapter->dev;
> > +
> > +	if (!dev->of_node)
> > +		goto err_exit;
> > +
> > +	adapter->dt_node = dev->of_node;
> 
> NAK
> 

regards,
jeff