Re: [PATCH v9 12/21] wifi: nxpwifi: introduce command and event handling infrastructure

From: Jeff Chen

Date: Wed Feb 11 2026 - 08:28:27 EST


On Wed, Feb 11, 2026 at 10:39:03 AM +0100, Krzysztof Kozlowski wrote:
> On 04/02/2026 19:03, Jeff Chen wrote:
> > +
> > + /*
> > + * Download calibration data to firmware.
> > + * The cal-data can be read from device tree and/or
> > + * a configuration file and downloaded to firmware.
> > + */
> > + if (adapter->dt_node) {
> > + if (of_property_read_u32(adapter->dt_node,
> > + "nxp,wakeup-pin",
>
> Don't sneak in ABI. This is not acceptable.
>
> NAK
>
>
> Best regards,
> Krzysztof
>

Acknowledged. This was not intentional — the DT property access was left
over from earlier bring-up work and should not appear in the upstream
submission without a proper binding. Thanks for pointing this out; I will
correct it in the next revision.

regards,
jeff