Re: [PATCH v8 3/8] irqchip/ls-extirq: Use for_each_of_imap_item iterator

[Herve Codina]

Hi Ioana,

On Wed, 11 Feb 2026 12:03:00 +0200
Ioana Ciornei <ioana.ciornei@xxxxxxx> wrote:

> On Wed, Jan 14, 2026 at 10:39:32AM +0100, Herve Codina (Schneider Electric) wrote:
> > The ls-extirq driver parses the interrupt-map property. It does it using
> > open code.
> > 
> > Recently for_each_of_imap_item iterator has been introduce to help
> > drivers in this parsing.
> > 
> > Convert the ls-extirq driver to use the for_each_of_imap_item
> > iterator instead of open code.
> >   
> 
> The ls-extirq uses interrupt-map but it's a non-standard use documented
> in fsl,ls-extirq.yaml:
> 
> 	# The driver(drivers/irqchip/irq-ls-extirq.c) have not use standard DT
> 	# function to parser interrupt-map. So it doesn't consider '#address-size'
> 	# in parent interrupt controller, such as GIC.
> 	#
> 	# When dt-binding verify interrupt-map, item data matrix is spitted at
> 	# incorrect position. Remove interrupt-map restriction because it always
> 	# wrong.
> 
> This means that by using for_each_of_imap_item and the underlying
> of_irq_parse_imap_parent() on its interrupt-map property will
> effectively break its functionality.
> 
> Unfortunatelly, I am not sure how this can be fixed other than with a
> revert.
> 

Well, if this is the only solution due to non compliance with interrupt-map,
I am not opposed to the revert of the following patch:
  3ac6dfe3d7a23 ("irqchip/ls-extirq: Use for_each_of_imap_item iterator")

(SHA taken from next-20260205 tag)

Best regards,
Hervé