Re: [PATCH v5 1/4] mm: Add address apis for ptdescs

From: Dave Hansen

Date: Wed Feb 11 2026 - 15:13:22 EST


On 2/11/26 11:52, Vishal Moola (Oracle) wrote:
> +/**
> + * pgtable_alloc_addr - Allocate pagetables to get an address
> + * @gfp: GFP flags
> + * @order: desired pagetable order

FWIW, I don't like how pgtable_alloc_addr() looks in practice. It reads
like it is: "allocate a page table address", not "allocate a page
table". I don't have a better suggestion other than having:

pgtable_alloc()

that returns a page table pointer, a void*, and:

ptdesc_alloc()

which returns a ptdesc*. But I suspect that would get confusing at the
point that ptdescs _themselves_ start getting allocated.