Re: [PATCH v5 3/4] x86/mm/pat: Convert pmd code to use ptdescs
From: Vishal Moola (Oracle)
Date: Wed Feb 11 2026 - 16:46:16 EST
On Wed, Feb 11, 2026 at 12:07:05PM -0800, Dave Hansen wrote:
> On 2/11/26 11:52, Vishal Moola (Oracle) wrote:
> > Also, rename *_pmd_page() functions to *_pmd(). Rename them now to avoid
> > any confusion later. Eventually these allocations will be backed by a
> > ptdesc not a page, but that's not important to callers either.
>
> So, pages are still a thing, whether the API says 'struct page' or not.
> The hardware kinda uses pages for page tables. ;)
>
> Could we please leave out the unnecessary churn from the renames?
Yeah I'll drop the renames. I thought it'd be better for
correctness-sake, as the idea is to "allocate memory for a page table"
rather than "allocate a generic page for a page table."
As long as its using the right APIs the naming doesn't really matter
to me.