Re: [PATCHv2] mm: khugepaged: make scan loops suspend aware

[Sergey Senozhatsky]

On (26/02/12 09:30), David Hildenbrand (Arm) wrote:
[..]
> > > > -static inline int hpage_collapse_test_exit_or_disable(struct mm_struct *mm)
> > > > +static inline int hpage_collapse_test_exit_or_disable(struct mm_struct *mm,
> > > > +						struct collapse_control *cc)
> > > 
> > > Two-tab indent, please.
> > 
> > I initially had it like
> > 
> > @@ -393,7 +393,7 @@ static inline int hpage_collapse_test_exit(struct mm_struct *mm)
> >   }
> >   static inline int hpage_collapse_test_exit_or_disable(struct mm_struct *mm,
> > -						struct collapse_control *cc)
> > +						      struct collapse_control *cc)
> >   {
> > 
> > but wasn't sure about the 80-col breakage.  Is that what you meant by
> > two-tab indent?
> 
> In MM we prefer
> 
> static inline int hpage_collapse_test_exit_or_disable(struct mm_struct *mm,
> 		struct collapse_control *cc)
> 
> 		^ two tabs

Ack.

I certainly see "(" alignment in that file (e.g. khugepaged_scan_mm_slot(),
__collapse_huge_page_copy_failed(), etc.) so I thought that maybe that was
what you meant.