Re: [PATCH 1/1] ASoC: dt-bindings: Convert eukrea-tlv320.txt to yaml

[Daniel Baluta]

On Wed, Feb 11, 2026 at 11:49 PM Frank Li <Frank.Li@xxxxxxx> wrote:
>
> Convert eukrea-tlv320.txt to yaml format.
>
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
>  .../bindings/sound/eukrea,asoc-tlv320.yaml    | 53 +++++++++++++++++++
>  .../bindings/sound/eukrea-tlv320.txt          | 26 ---------
>  2 files changed, 53 insertions(+), 26 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/eukrea,asoc-tlv320.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/eukrea-tlv320.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/eukrea,asoc-tlv320.yaml b/Documentation/devicetree/bindings/sound/eukrea,asoc-tlv320.yaml
> new file mode 100644
> index 0000000000000..483507fa77937
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/eukrea,asoc-tlv320.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/eukrea,asoc-tlv320.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Audio complex for Eukrea boards with tlv320aic23 codec.
> +
> +maintainers:
> +  - Frank Li <Frank.Li@xxxxxxx>
> +
> +properties:
> +  compatible:
> +    const: eukrea,asoc-tlv320
> +
> +  eukrea,model:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description:
> +      The user-visible name of this sound complex.
> +
> +  ssi-controller:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      The phandle of the SSI controller.
> +
> +  fsl,mux-int-port:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      The internal port of the i.MX audio muxer (AUDMUX).

Same comment about port numbering applies also for mux-int-port. So
better add it here too.


> +
> +  fsl,mux-ext-port:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      The external port of the i.MX audio muxer.
> +      Note: The AUDMUX port numbering should start at 1, which is consistent with
> +      hardware manual.
> +
> +required:
> +  - compatible
> +  - eukrea,model
> +  - ssi-controller
> +
> +additionalProperties: false

The driver sound/soc/fsl/eukrea-tlv320.c allows an optional property
named codec-handle
so I'm not sure additionalProperties: false is correct here.