[PATCH v1 1/2] ACPI: button: Tweak system wakeup handling

From: Rafael J. Wysocki

Date: Thu Feb 12 2026 - 08:34:06 EST


From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Modify struct acpi_button to hold a struct device pointer instead
of a struct platform_device one to avoid unnecessary pointer
dereferences and use that pointer consistently for system wakeup
initialization, handling and cleanup.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
---
drivers/acpi/button.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c
@@ -170,7 +170,7 @@ static struct platform_driver acpi_butto

struct acpi_button {
struct acpi_device *adev;
- struct platform_device *pdev;
+ struct device *dev; /* physical button device */
unsigned int type;
struct input_dev *input;
char phys[32]; /* for input device */
@@ -398,7 +398,7 @@ static int acpi_lid_update_state(struct
return state;

if (state && signal_wakeup)
- acpi_pm_wakeup_event(&button->pdev->dev);
+ acpi_pm_wakeup_event(button->dev);

return acpi_lid_notify_state(button, state);
}
@@ -455,7 +455,7 @@ static void acpi_button_notify(acpi_hand
return;
}

- acpi_pm_wakeup_event(&button->pdev->dev);
+ acpi_pm_wakeup_event(button->dev);

if (button->suspended || event == ACPI_BUTTON_NOTIFY_WAKE)
return;
@@ -550,7 +550,7 @@ static int acpi_button_probe(struct plat

platform_set_drvdata(pdev, button);

- button->pdev = pdev;
+ button->dev = &pdev->dev;
button->adev = device;
button->input = input = input_allocate_device();
if (!input) {
@@ -625,7 +625,7 @@ static int acpi_button_probe(struct plat
goto err_remove_fs;
}

- device_init_wakeup(&pdev->dev, true);
+ device_init_wakeup(button->dev, true);

switch (device->device_type) {
case ACPI_BUS_TYPE_POWER_BUTTON:
@@ -661,7 +661,7 @@ static int acpi_button_probe(struct plat
return 0;

err_input_unregister:
- device_init_wakeup(&pdev->dev, false);
+ device_init_wakeup(button->dev, false);
input_unregister_device(input);
err_remove_fs:
acpi_button_remove_fs(button);
@@ -693,7 +693,7 @@ static void acpi_button_remove(struct pl
}
acpi_os_wait_events_complete();

- device_init_wakeup(&pdev->dev, false);
+ device_init_wakeup(button->dev, false);

acpi_button_remove_fs(button);
input_unregister_device(button->input);