Re: [PATCH v3] staging: sm750fb: Rename nDirection to new_direction
From: Dan Carpenter
Date: Thu Feb 12 2026 - 10:01:44 EST
On Thu, Feb 12, 2026 at 12:58:42PM +0200, RachelOvrani wrote:
> Rename the variable 'nDirection' to 'new_direction'
> to fix the warning reported by checkpatch.pl
>
> Signed-off-by: RachelOvrani <rachel.ovrani@xxxxxxxxx>
> ---
> v2 -> v3 : Change the commit message more appropriately
> v1 -> v2 : Renaming n_direction to new_direction
>
> drivers/staging/sm750fb/sm750_accel.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index e1877e5d0..c796d410c 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -153,9 +153,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
> unsigned int width, unsigned int height,
> unsigned int rop2)
> {
> - unsigned int n_direction, de_ctrl;
^^^^^^^^^^^
The old code should be nDirection so this isn't going to apply.
> + unsigned int new_direction, de_ctrl;
regards,
dan carpenter