Re: [PATCH v1] mm/damon: remove unused code

[SeongJae Park]

On Thu, 12 Feb 2026 09:43:26 +0000 <gutierrez.asier@xxxxxxxxxxxxxxxxxxx> wrote:

> From: Asier Gutierrez <gutierrez.asier@xxxxxxxxxxxxxxxxxxx>
> 
> damon_target is not used by get_scheme_score operations, nor with
> virtual neither with physical addresses.

Good finding, thank you for this patch, Asier!

The subject seems bit ambiguous, though.  What about "remove unused target
param of get_scheme_score()" ?

> 
> Signed-off-by: Asier Gutierrez <gutierrez.asier@xxxxxxxxxxxxxxxxxxx>

Other than the subject,

Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>

Also, DAMON patches are recommended to use mm-new as thier baseline [1] unless
there are other reasons to not to do so.  But I found 'git am' of this patch on
the mm-new fails.  It works on the master of mm.git, which is a commit of
Linus' tree, though.  So, maybe this patch is not using mm-new as the baseline?
Please consider using mm-new as the baseline next time, or specify why you use
choose different tree as the baseline.

Assuming you are ok to the subject change (let me know if you are not), I'm
attaching a new version of this patch that has changed the subject with my
suggestion, and manually resolved the conflicts on mm-new, for Andrew's
convenience.  I also applied that to my tree (damon/next), and I will repost it
if Andrew miss this (as we are in the middle of merge window, maintainers could
miss many things).

[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees


Thanks,
SJ

[...]
======= >8 =======