Re: [PATCH 1/1] arm64: dts: qcom: monaco-evk: Add Mezzanine

[Bjorn Andersson]

On Tue, Feb 10, 2026 at 04:08:21PM +0530, Umang Chheda wrote:
> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk-mezzanine.dtso b/arch/arm64/boot/dts/qcom/monaco-evk-mezzanine.dtso
[..]
> +&i2c15 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;

Do we need to repeat this? It's in the top-level i2c15 definition
already?

> +
> +	status = "okay";

I presume this overlay is used on top of monaco-evk.dtb, which already
says that status is okay.


That said, I don't see a "clock-frequency" in either node, so I presume
you have an error/warning in your kernel log about this. But unless you
have reason to change that in your overlay, I think that's a unrelated
patch on the monaco-evk.dts - which I would like you to send, separately.

> +
> +	eeprom1: eeprom@52 {
> +		compatible = "giantec,gt24c256c", "atmel,24c256";
> +		reg = <0x52>;
> +		pagesize = <64>;
> +
> +		nvmem-layout {
> +			compatible = "fixed-layout";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +		};
> +	};
> +};
> +
[..]
> +&tlmm {
> +	tc9563_resx_n: tc9563-resx-state {
> +		pins = "gpio124";
> +		function = "gpio";
> +
> +		bias-disable;
> +		input-disable;
> +		output-enable;
> +		power-source = <0>;

Does these properties really match the TLMM binding? Please double
check.

Regards,
Bjorn

> +	};
> +};
> --
> 2.34.1
>