Re: [PATCH 0/2] smb: simplify boolean expressions

[Steve French]

After getting feedback from others, it was felt that these two patches
(eliminating the "== true" and "== false") don't improve readability
enough to justify the risk that they would complicate future backports
of fixes.   If we were already changing related code for a fix then
cleanup like this could be added on to a fix but not worth the risk if
not related to a fix

On Mon, Feb 9, 2026 at 11:57 AM Adarsh Das <adarshdas950@xxxxxxxxx> wrote:
>
> This series simplifies boolean expressions in the SMB code by removing
> redundant comparisons with true/false.
>
> Adarsh Das (2):
>   smb: remove redundant == true comparisons
>   smb: remove redundant == false comparisons
>
>  fs/smb/client/cifsacl.c        |  2 +-
>  fs/smb/client/connect.c        |  6 ++---
>  fs/smb/client/file.c           |  5 ++--
>  fs/smb/client/fs_context.c     |  6 ++---
>  fs/smb/client/misc.c           |  2 +-
>  fs/smb/client/smb2misc.c       |  4 ++--
>  fs/smb/client/smb2ops.c        | 12 +++++-----
>  fs/smb/client/smb2pdu.c        |  2 +-
>  fs/smb/client/transport.c      |  2 +-
>  fs/smb/server/oplock.c         |  6 ++---
>  fs/smb/server/server.c         |  2 +-
>  fs/smb/server/smb2misc.c       |  2 +-
>  fs/smb/server/smb2pdu.c        | 44 ++++++++++++++++------------------
>  fs/smb/server/smb_common.c     |  2 +-
>  fs/smb/server/transport_rdma.c |  2 +-
>  fs/smb/server/vfs.c            |  8 +++----
>  fs/smb/server/vfs_cache.c      |  6 ++---
>  17 files changed, 55 insertions(+), 58 deletions(-)
>
> --
> 2.53.0
>
>


-- 
Thanks,

Steve