Re: [PATCH] riscv: kdump: return early for invalid 'crashkernel=0' input

[Paul Walmsley]

Hi,

On Fri, 6 Feb 2026, Austin Kim wrote:

> From: Austin Kim <austin.kim@xxxxxxx>
> 
> An invalid 'crashkernel=0' can be specified when running kdump.
> By adding a check for 'crashkernel=0', it can return early when detecting
> this invalid input.
> 
> Signed-off-by: Austin Kim <austin.kim@xxxxxxx>
> ---
>  arch/riscv/mm/init.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index 811e03786..e61fec445 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -1409,7 +1409,8 @@ static void __init arch_reserve_crashkernel(void)
>  	ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(),
>  				&crash_size, &crash_base,
>  				&low_size, NULL, &high);
> -	if (ret)
> +	/* invalid value specified or 'crashkernel=0' */
> +	if (ret || !crash_size)
>  		return;
>  
>  	reserve_crashkernel_generic(crash_size, crash_base, low_size, high);

Should this fix the common code in kernel/crash_reserve.c to return an 
error code when crashkernel=0 so it benefits other architectures?


- Paul