Re: [PATCH v9 0/2] Add driver support for Eswin EIC7700 SoC SATA PHY

[Yulin Lu]

> Updates:
>   v9 -> v8:
>     - eswin,eic7700-sata-phy.yaml
>       - Modify the format of the "default" field in the
>         "eswin,tx-amplitude-tuning" and "eswin,tx-preemph-tuning"
>         properties.
>     - phy-eic7700-sata.c
>       - Correct the incorrectly formatted symbol "-" in the comments.
>     - Link to v8: https://lore.kernel.org/lkml/20260123024823.1612-1-luyulin@xxxxxxxxxxxxxxxxxx/
> 
>   v8 -> v7:
>     - eswin,eic7700-sata-phy.yaml
>       - Add "eswin,tx-amplitude-tuning" and "eswin,tx-preemph-tuning"
>         properties, because these parameters may vary across different
>         circuit boards.
>       - Delete reviewed-by tag of Krzysztof Kozlowski, because the tuning
>         properties are introduced.
>     - phy-eic7700-sata.c
>       - Try to get SATA PHY transmitter amplitude and pre-emphasis signal
>         eye diagram tuning parameters from dts instead of hardcoded values
>         in the code. Because, these parameters may vary across different
>         circuit boards. Define default tuning parameters and use it when
>         these properties are not declared in dts.
>       - Add a comment to explain the reason for mapping I/O resources with
>         platform_get_resource and devm_ioremap instead of using the
>         devm_platform_ioremap_resource API.
>     - Link to v7: https://lore.kernel.org/lkml/20260106062944.1529-1-luyulin@xxxxxxxxxxxxxxxxxx/

Hi Vinod, all,

In v7, I got driver review comments from Vinod. After fixing and submitting v8,
I received yaml comments from Krzysztof. v9 now has Reviewed-by from Krzysztof.
So I want to confirm whether there are any further comments on the driver code
in v9 and if it meets the requirements for merging.

Best regards,
Yulin Lu