Re: [PATCH v4 1/2] dt-bindings: iio: light: vcnl4000: add Capella CM36686 and CM36672P

[Krzysztof Kozlowski]

On 13/02/2026 09:29, Erikas Bitovtas wrote:
>>> Signed-off-by: Erikas Bitovtas <xerikasxx@xxxxxxxxx>
>>> ---
>>>  .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml  | 17 +++++++++++------
>>>  1 file changed, 11 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
>>> index 4d1a225e8868..2ba4d5de4ec4 100644
>>> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
>>> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
>>> @@ -18,12 +18,17 @@ allOf:
>>>  
>>>  properties:
>>>    compatible:
>>> -    enum:
>>> -      - vishay,vcnl4000
>>> -      - vishay,vcnl4010
>>> -      - vishay,vcnl4020
>>> -      - vishay,vcnl4040
>>> -      - vishay,vcnl4200
>>> +    oneOf:
>>> +      - enum:
>>> +          - capella,cm36672p
>>
>> CM36672P is compatible with CM36686, but this is not expressed.
>> Confusing commit msg and code. 
> 
> For CM36672P we create a dedicated compatible because it is a
> proximity-only sensor which has the same proximity sensor configuration,
> but ambient light sensor registers are missing (reserved).

I don't understand this. You just wrote "fully compatible with CM36686"
and now you imply that not.

Decide.

Best regards,
Krzysztof