Re: [PATCH v4 5/6] dt-bindings: media: mediatek,vcodec-encoder: Add MT8196 with VCP support
From: Krzysztof Kozlowski
Date: Fri Feb 13 2026 - 04:53:03 EST
On 13/02/2026 10:47, Irui Wang (王瑞) wrote:
>>>>
>>>> And here still did not implement the comment. So basically you
>>>> did
>>>> not
>>>> implement fully v2 and v3.
>>>
>>> If you are mean about the `else statement`, I left a comments and
>>> want
>>> to get an explanation from you, if you feel that my reply is
>>> unsatisfactory or incorrect, please let me know.
>>>
>>> The key point is that our patch can satisfy you and get a Reviewed-
>>> by
>>> from you.
>>>
>>
>> Neither your answer, nor commit description here are actually
>> ANSWERING
>> to my comment at v3. If you answer with irrelevant/unrelated comment,
>> the reviewer's feedback stays. OR explain please with different words
>> why other devices have vcp but your commit msg says they do not have
>> vcp.
>
> Why other devices have vcp? because I didn't write 'mediatek,vcp:false'
> in else statement?
Yes
Best regards,
Krzysztof