Re: [PATCH 3/4] arm64: dts: qcom: pm7250b: Enable Qualcomm BCL device

[Manaf Meethalavalappu Pallikunhi]

Hi Krzysztof,

On 2/6/2026 1:43 PM, Krzysztof Kozlowski wrote:
> On Fri, Feb 06, 2026 at 02:44:07AM +0530, Manaf Meethalavalappu Pallikunhi wrote:
> > Enable Qualcomm BCL hardware devicetree binding configuration
> > for pm7250b.
> >
> > Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/pm7250b.dtsi | 10 ++++++++++
> >   1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> > index 0761e6b5fd8d..69ad76831cde 100644
> > --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> > @@ -202,6 +202,16 @@ pm7250b_gpios: gpio@c000 {
> >   			interrupt-controller;
> >   			#interrupt-cells = <2>;
> >   		};
> > +
> > +		bcl@1d00 {
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> If you cannot find a name matching your device, please check in kernel
> sources for similar cases or you can grow the spec (via pull request to
> DT spec repo).
Ack, I will use node as "sensor" as we are enabling hwmon sensors here.
> Plus, I doubt this was ever tested. Considering lack of internal review
> I do not think this should be posted.
It is tested on qcs6490-rb3gen2 for pm7250b BCL and pm8350c bcl
> Best regards,
> Krzysztof