Re: [PATCH] uio: fix uio_unregister_device
From: gregkh@xxxxxxxxxxxxxxxxxxx
Date: Fri Feb 13 2026 - 07:17:21 EST
On Fri, Feb 13, 2026 at 12:09:04PM +0000, Igor Klochko (Nokia) wrote:
> Hi Greg,
>
> > Nice fix, but what is causing these devices to be created and removed in parallel?
> It's an outcome of a stress test.
>
> > Nit, line wrapping at the same column width :)
> > Please use more digits, as the documentation mentions.
> Acknowledged, will resend the patch.
>
> > So no locking is needed here? It's only the minor that is getting messed up?
>
> Only minor. If I look at the history, 0c9ae0b8605078eafc3bea053cc78791e97ba2e2 moved the minor before device unregister.
>
> However, this breaks a fix done in
> 8fd0e2a6df262539eaa28b0a2364cca10d1dc662
> uio: free uio id after uio file node is freed
>
> > And should this be cc: stable?
>
> 0c9ae0b8605078eafc3bea053cc78791e97ba2e2 is a CVE, so it was applied on LTS kernels, we discovered this on 6.1.
> I thought stable is the right place for these kinds of patches.
I agree, it is, but you need to add "cc: stable@..." to the
signed-off-by area of the patch, as the bot referred to to, if you want
that to happen.
Can you resend this with that added, AND the sha1 fixed up for the
Fixes: tag?
thanks,
greg k-h