Re: [PATCH v2] arm64: defconfig: tpm : Enable fTPM TEE support

[Andrew Davis]

On 2/11/26 12:22 AM, Krzysztof Kozlowski wrote:
> On 11/02/2026 07:15, Atharv Dubey wrote:
> > Enable CONFIG_TCG_FTPM_TEE as a module for all
> > the platforms to support firmware-based TPM
> > through OP-TEE.
>
> What all platforms? Again, this is not your distro defconfig. Explain
> why do we want it in upstream.

"All" seems correct here, the fTPM TA is usable by any ARM64 platform
with OP-TEE support, which looks to be just about everyone[0].

Why do we want it upstream?: to support firmware-based TPM
through OP-TEE.

What more are you looking for, how do we prove some feature that was
deemed useful enough to include in the kernel is useful enough to enable?

> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> > Bloat-o-meter Statistics :
> > add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
> > Function  old           new             delta
> > Total: Before=32968311, After=32968311, chg +0.00%
>
> Really? You put here a proof that not enabling built-in has no built-in
> impact?

Does it hurt to add? You never know if there are follow-on effects due
to definitions when setting a module (yes that would probably be a bug
but it can happen). Rules like "add Bloat-o-meter results to defconfig
change patches" work much better when you don't add "except when it's
obvious to Krzysztof that there should be no size change"..

Andrew

[0] https://github.com/OP-TEE/optee_os/tree/master/core/arch/arm

> Best regards,
> Krzysztof