Re: [PATCH 1/2] dt-bindings: input: add GPIO charlieplex keypad

[Hugo Villeneuve]

On Thu, 5 Feb 2026 01:24:05 -0800
Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:

Hi Dmitry,

> Hi Hugo,
> 
> On Tue, Feb 03, 2026 at 10:49:47AM -0500, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> > 
> > Add DT bindings for GPIO charlieplex keypad.
> > 
> 
> ...
> 
> > +  linux,no-autorepeat:
> > +    type: boolean
> > +    description: Do not enable autorepeat feature.
> 
> Let's use standard "autorepeat" property to enable autorepeat when
> needed.

Ok, I based my binding/driver on gpio-matrix-keypad, which had
linux,no-autorepeat.
I will change that in V2 (along with driver source code changes).

> 
> > +
> > +  gpio-activelow:
> > +    type: boolean
> > +    description:
> > +      Force GPIO polarity to active low.
> > +      In the absence of this property GPIOs are treated as active high.
> 
> No, the polarity should be encoded in individual GPIOs, not via a
> separate property.

You are right, again "contamination" from gpio-matrix-keypad :)

I will also change that in V2 (along with driver source code changes).

Thank you,
Hugo.