Re: [PATCH v2 2/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

From: M Henning

Date: Fri Feb 13 2026 - 17:07:26 EST


On Fri, Feb 13, 2026 at 12:14 PM Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
>
> On Thu Feb 5, 2026 at 7:56 PM CET, Mel Henning wrote:
> > +int
> > +nouveau_abi16_ioctl_get_zcull_info(ABI16_IOCTL_ARGS)
> > +{
> > + struct nouveau_drm *drm = nouveau_drm(dev);
> > + struct nvkm_gr *gr = nvxx_gr(drm);
> > + struct drm_nouveau_get_zcull_info *out = data;
> > +
> > + if (gr->has_zcull_info) {
> > + const struct nvkm_gr_zcull_info *i = &gr->zcull_info;
> > +
> > + out->width_align_pixels = i->width_align_pixels;
> > + out->height_align_pixels = i->height_align_pixels;
> > + out->pixel_squares_by_aliquots = i->pixel_squares_by_aliquots;
> > + out->aliquot_total = i->aliquot_total;
> > + out->zcull_region_byte_multiplier = i->zcull_region_byte_multiplier;
> > + out->zcull_region_header_size = i->zcull_region_header_size;
> > + out->zcull_subregion_header_size = i->zcull_subregion_header_size;
> > + out->subregion_count = i->subregion_count;
> > + out->subregion_width_align_pixels = i->subregion_width_align_pixels;
> > + out->subregion_height_align_pixels = i->subregion_height_align_pixels;
> > + out->ctxsw_size = i->ctxsw_size;
> > + out->ctxsw_align = i->ctxsw_align;
> > +
> > + return 0;
> > + } else {
> > + return -ENODEV;
>
> ENODEV usually means that that device fell off the bus, I think ENOTTY would be
> a better fit.

Done.

> > + }
> > +}