Re: [PATCH 1/2] gpiolib: of: add gpio-line node support

From: Krzysztof Kozlowski

Date: Sat Feb 14 2026 - 04:08:33 EST


On Fri, Feb 13, 2026 at 03:32:01PM -0700, James Hilliard wrote:
> diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c
> index b3525d1f06a4..b934e58a07f0 100644
> --- a/drivers/gpio/gpiolib-shared.c
> +++ b/drivers/gpio/gpiolib-shared.c
> @@ -147,10 +147,11 @@ static bool gpio_shared_of_node_ignore(struct device_node *node)
> return true;
>
> /*
> - * GPIO hogs have a "gpios" property which is not a phandle and can't
> - * possibly refer to a shared GPIO.
> + * GPIO hog and gpio-line nodes have a "gpios" property which is not a
> + * phandle and can't possibly refer to a shared GPIO.
> */
> - if (of_property_present(node, "gpio-hog"))
> + if (of_property_present(node, "gpio-hog") ||
> + of_property_present(node, "gpio-line"))

Please organize the patch documenting the compatible (DT bindings)
before the patch using that compatible.
See also: https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46


Best regards,
Krzysztof