Re: [PATCH] media: malic55: Fix possible ERR_PTR deference in enable_streams

From: Markus Elfring

Date: Sat Feb 14 2026 - 09:37:44 EST



> pointer or an ERR_PTR() on failure …

error pointer


> Add proper error checking with IS_ERR() before dereferencing the
> pointer. Also set isp->remote_src to NULL on error to maintain
> consistency with other error paths in the function.


* See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.19#n34

* Were any source code analysis tools involved here?

* Would a summary phrase like “Prevent error pointer dereference
in mali_c55_isp_enable_streams()” be more appropriate?


Regards,
Markus