Re: [PATCH v6 3/3] iio: magnetometer: bmc150_magn: minor formatting cleanup

[David Lechner]

On 2/10/26 5:39 PM, Neel Bullywon wrote:
> Improve initializer list style for bmc150_magn_samp_freq_table by
> moving the opening brace to its own line and grouping four entries
> per line with index comments.
> 
> Add spaces inside braces for initializer lists in the preset table
> for consistency.
> 
> Fix indentation of bmc150_magn_scan_masks array. No functional changes.
> 
> Signed-off-by: Neel Bullywon <neelb2403@xxxxxxxxx>
> ---
>  drivers/iio/magnetometer/bmc150_magn.c | 25 +++++++++++--------------
>  1 file changed, 11 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c
> index f254774d28e5..942c2f5e97e1 100644
> --- a/drivers/iio/magnetometer/bmc150_magn.c
> +++ b/drivers/iio/magnetometer/bmc150_magn.c
> @@ -149,14 +149,10 @@ struct bmc150_magn_data {
>  static const struct {
>  	int freq;
>  	u8 reg_val;
> -} bmc150_magn_samp_freq_table[] = { {2, 0x01},
> -				    {6, 0x02},
> -				    {8, 0x03},
> -				    {10, 0x00},
> -				    {15, 0x04},
> -				    {20, 0x05},
> -				    {25, 0x06},
> -				    {30, 0x07} };
> +} bmc150_magn_samp_freq_table[] = {
> +	{ 2, 0x01 }, { 6, 0x02 }, { 8, 0x03 }, { 10, 0x00 },		/* 0 - 3 */
> +	{ 15, 0x04 }, { 20, 0x05 }, { 25, 0x06 }, { 30, 0x07 },	    /* 4 - 7 */
> +};
>  
Just an opinion: I think it is easier to see the patterns in
the numbers if we leave it as one struct per line. (Fixing
the indent and padding is still an improvement.)